Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various memory leak fixes #300

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Various memory leak fixes #300

merged 9 commits into from
Sep 20, 2024

Conversation

alltilla
Copy link
Member

@alltilla alltilla commented Sep 20, 2024 •
edited
Loading

Fixes the following memory leaks:

==95913== 20 bytes in 4 blocks are definitely lost in loss record 97 of 1,829
==95913==    at 0x4843808: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4C14589: strdup (strdup.c:42)
==95913==    by 0x48AABD5: cfg_lexer_lookup_keyword (cfg-lexer.c:257)
==95913==    by 0x48AAF28: cfg_lexer_map_word_to_token (cfg-lexer.c:302)
==95913==    by 0x48EA0B7: _cfg_lexer_lex (cfg-lex.l:352)
==95913==    by 0x48AC8C0: _invoke__cfg_lexer_lex (cfg-lexer.c:971)
==95913==    by 0x48ACAD1: cfg_lexer_lex_next_token (cfg-lexer.c:1015)
==95913==    by 0x48AD0AE: cfg_lexer_lex (cfg-lexer.c:1202)
==95913==    by 0x492727F: filterx_lex (filterx-parser.c:70)
==95913==    by 0x4941CC6: filterx_parse (filterx-grammar.c:3802)
==95913==    by 0x48AF069: cfg_parser_parse (cfg-parser.c:299)
==95913==    by 0x490463A: main_parse (cfg-grammar.y:715)


==95913== 230 (104 direct, 126 indirect) bytes in 1 blocks are definitely lost in loss record 1,519 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x48C8ACE: _set_metric_options (logsource.c:738)
==95913==    by 0x48C8B62: log_source_set_options (logsource.c:756)
==95913==    by 0x48C43FD: log_reader_set_options (logreader.c:79)
==95913==    by 0x9C8E319: afsocket_sc_init (afsocket-source.c:186)
==95913==    by 0x9C8DC87: log_pipe_init (logpipe.h:387)
==95913==    by 0x9C8ED3A: afsocket_sd_process_connection (afsocket-source.c:480)
==95913==    by 0x9C907D2: _sd_open_dgram (afsocket-source.c:1137)
==95913==    by 0x9C908FC: afsocket_sd_open_listener (afsocket-source.c:1166)
==95913==    by 0x9C9108F: afsocket_sd_init_method (afsocket-source.c:1328)


==95913== 258 (104 direct, 154 indirect) bytes in 1 blocks are definitely lost in loss record 1,530 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x48C8A1F: _set_metric_options (logsource.c:730)
==95913==    by 0x48C8B62: log_source_set_options (logsource.c:756)
==95913==    by 0x48C43FD: log_reader_set_options (logreader.c:79)
==95913==    by 0x9C8E319: afsocket_sc_init (afsocket-source.c:186)
==95913==    by 0x9C8DC87: log_pipe_init (logpipe.h:387)
==95913==    by 0x9C8ED3A: afsocket_sd_process_connection (afsocket-source.c:480)
==95913==    by 0x9C907D2: _sd_open_dgram (afsocket-source.c:1137)
==95913==    by 0x9C908FC: afsocket_sd_open_listener (afsocket-source.c:1166)
==95913==    by 0x9C9108F: afsocket_sd_init_method (afsocket-source.c:1328)


==95913== 460 (208 direct, 252 indirect) bytes in 2 blocks are definitely lost in loss record 1,548 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x48C8ACE: _set_metric_options (logsource.c:738)
==95913==    by 0x48C8B62: log_source_set_options (logsource.c:756)
==95913==    by 0x48C43FD: log_reader_set_options (logreader.c:79)
==95913==    by 0x9C8E319: afsocket_sc_init (afsocket-source.c:186)
==95913==    by 0x9C8DC87: log_pipe_init (logpipe.h:387)
==95913==    by 0x9C90363: afsocket_sd_restore_kept_alive_connections (afsocket-source.c:1021)
==95913==    by 0x9C91083: afsocket_sd_init_method (afsocket-source.c:1326)
==95913==    by 0x9C945CB: afinet_sd_init (afinet-source.c:104)
==95913==    by 0x48B0F0A: log_pipe_init (logpipe.h:387)


==95913== 516 (208 direct, 308 indirect) bytes in 2 blocks are definitely lost in loss record 1,552 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x48C8A1F: _set_metric_options (logsource.c:730)
==95913==    by 0x48C8B62: log_source_set_options (logsource.c:756)
==95913==    by 0x48C43FD: log_reader_set_options (logreader.c:79)
==95913==    by 0x9C8E319: afsocket_sc_init (afsocket-source.c:186)
==95913==    by 0x9C8DC87: log_pipe_init (logpipe.h:387)
==95913==    by 0x9C90363: afsocket_sd_restore_kept_alive_connections (afsocket-source.c:1021)
==95913==    by 0x9C91083: afsocket_sd_init_method (afsocket-source.c:1326)
==95913==    by 0x9C945CB: afinet_sd_init (afinet-source.c:104)
==95913==    by 0x48B0F0A: log_pipe_init (logpipe.h:387)


==95913== 610 (208 direct, 402 indirect) bytes in 2 blocks are definitely lost in loss record 1,573 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x498AE8B: _register_driver_stats (logthrdestdrv.c:1270)
==95913==    by 0x498B48B: log_threaded_dest_driver_init_method (logthrdestdrv.c:1411)
==95913==    by 0xB988F3E: http_dd_init (http.c:442)
==95913==    by 0x48B0F0A: log_pipe_init (logpipe.h:387)
==95913==    by 0x48B3B97: cfg_tree_start (cfg-tree.c:1586)
==95913==    by 0x48A80FC: cfg_init (cfg.c:308)
==95913==    by 0x48D005D: main_loop_initialize_state (mainloop.c:203)
==95913==    by 0x48D1258: main_loop_read_and_init_config (mainloop.c:700)
==95913==    by 0x10AA39: main (main.c:319)


==95913== 1,364 bytes in 8 blocks are definitely lost in loss record 1,729 of 1,829
==95913==    at 0x4843808: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4C14589: strdup (strdup.c:42)
==95913==    by 0x48F09CB: _cfg_lexer_lex (cfg-lex.l:383)
==95913==    by 0x48AC8C0: _invoke__cfg_lexer_lex (cfg-lexer.c:971)
==95913==    by 0x48ACAD1: cfg_lexer_lex_next_token (cfg-lexer.c:1015)
==95913==    by 0x48AD0AE: cfg_lexer_lex (cfg-lexer.c:1202)
==95913==    by 0x48DCA1E: pragma_lex (pragma-parser.c:91)
==95913==    by 0x490A86C: pragma_parse (pragma-grammar.c:3486)
==95913==    by 0x48AF069: cfg_parser_parse (cfg-parser.c:299)
==95913==    by 0x48ACEE0: cfg_lexer_parse_pragma (cfg-lexer.c:1119)
==95913==    by 0x48ACFD2: cfg_lexer_preprocess (cfg-lexer.c:1163)
==95913==    by 0x48AD24D: cfg_lexer_lex (cfg-lexer.c:1242)


==95913== 1,600 (576 direct, 1,024 indirect) bytes in 8 blocks are definitely lost in loss record 1,749 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x495B65C: value_pairs_new (value-pairs.c:992)
==95913==    by 0x4967319: dyn_metrics_template_new (dyn-metrics-template.c:142)
==95913==    by 0x4967397: dyn_metrics_template_clone (dyn-metrics-template.c:158)
==95913==    by 0x9CEAE06: _clone (metrics-probe.c:160)
==95913==    by 0x48B1078: log_pipe_clone (logpipe.h:498)
==95913==    by 0x48B2542: cfg_tree_compile_single (cfg-tree.c:777)
==95913==    by 0x48B34D9: cfg_tree_compile_node (cfg-tree.c:1370)
==95913==    by 0x48B2B9C: cfg_tree_compile_sequence (cfg-tree.c:1019)
==95913==    by 0x48B3531: cfg_tree_compile_node (cfg-tree.c:1376)
==95913==    by 0x48B2937: cfg_tree_compile_reference (cfg-tree.c:905)


==95913== 1,830 (624 direct, 1,206 indirect) bytes in 6 blocks are definitely lost in loss record 1,751 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x49645EA: stats_cluster_key_builder_build_single (stats-cluster-key-builder.c:386)
==95913==    by 0x498AE8B: _register_driver_stats (logthrdestdrv.c:1270)
==95913==    by 0x498B48B: log_threaded_dest_driver_init_method (logthrdestdrv.c:1411)
==95913==    by 0xB988F3E: http_dd_init (http.c:442)
==95913==    by 0x48B0F0A: log_pipe_init (logpipe.h:387)
==95913==    by 0x48B3B97: cfg_tree_start (cfg-tree.c:1586)
==95913==    by 0x48A80FC: cfg_init (cfg.c:308)
==95913==    by 0x48D02C1: main_loop_reload_config_apply (mainloop.c:287)
==95913==    by 0x48D2622: _consume_action (mainloop-worker.c:258)
==95913==    by 0x48D265A: _invoke_sync_call_actions (mainloop-worker.c:268)


==95913== 1,856 (256 direct, 1,600 indirect) bytes in 8 blocks are definitely lost in loss record 1,753 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x4967309: dyn_metrics_template_new (dyn-metrics-template.c:140)
==95913==    by 0x9CEAF2F: metrics_probe_new (metrics-probe.c:191)
==95913==    by 0x9CEADD1: _clone (metrics-probe.c:157)
==95913==    by 0x48B1078: log_pipe_clone (logpipe.h:498)
==95913==    by 0x48B2542: cfg_tree_compile_single (cfg-tree.c:777)
==95913==    by 0x48B34D9: cfg_tree_compile_node (cfg-tree.c:1370)
==95913==    by 0x48B2B9C: cfg_tree_compile_sequence (cfg-tree.c:1019)
==95913==    by 0x48B3531: cfg_tree_compile_node (cfg-tree.c:1376)
==95913==    by 0x48B2937: cfg_tree_compile_reference (cfg-tree.c:905)
==95913==    by 0x48B3505: cfg_tree_compile_node (cfg-tree.c:1373)


==95913== 10,496 bytes in 656 blocks are definitely lost in loss record 1,801 of 1,829
==95913==    at 0x48489F3: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==95913==    by 0x4A87BD9: g_malloc0 (gmem.c:133)
==95913==    by 0x7F81888: transformation_step_new (transformation.c:30)
==95913==    by 0x7F81924: transformation_block_add_step (transformation.c:48)
==95913==    by 0x7F83418: appmodel_parse (appmodel-grammar.y:596)
==95913==    by 0x48AF069: cfg_parser_parse (cfg-parser.c:299)
==95913==    by 0x48DAB1A: plugin_construct_from_config (plugin.c:111)
==95913==    by 0x48A7CBC: cfg_parse_plugin (cfg.c:223)
==95913==    by 0x4904301: main_parse (cfg-grammar.y:635)
==95913==    by 0x48AF069: cfg_parser_parse (cfg-parser.c:299)
==95913==    by 0x48A8953: cfg_run_parser (cfg.c:534) 
==95913==    by 0x48A8F2D: cfg_read_config (cfg.c:655)

Note: reloading was necessary to trigger some of these.

bazsi
bazsi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, looks there are some really good catches in here.

@bazsi bazsi merged commit 5158c53 into axoflow:main Sep 20, 2024
22 checks passed
@HofiOne HofiOne mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverOrion OverOrion OverOrion approved these changes

@bazsi bazsi bazsi approved these changes

@bshifter bshifter Awaiting requested review from bshifter

@MrAnno MrAnno Awaiting requested review from MrAnno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alltilla @bazsi @OverOrion